Review Request 114741: Add time duration to media item for youtube videos.

Sudhendu Kumar sudhendu.kumar.roy at gmail.com
Tue Dec 31 06:46:38 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114741/
-----------------------------------------------------------

(Updated Dec. 31, 2013, 6:46 a.m.)


Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.


Changes
-------

Moved formatting of time from Model to View.


Repository: plasma-mediacenter


Description
-------

While searching for youtube videos from PMC, it was difficult to differentiate among the videos of same kind but different duration.
This feature adds the duration of video at top-right corner of thumbnail.
Snapshot added along with this review.


Diffs (updated)
-----

  libs/mediacenter/mediacenter.h 7cdf285 
  libs/mediacenter/mediacenter.cpp 009ce22 
  browsingbackends/onlineservices/youtube/youtubemodel.cpp abb4f89 
  components/common/LabelOverlay.qml fd722af 
  components/common/MediaItem.qml ccdc8c2 

Diff: https://git.reviewboard.kde.org/r/114741/diff/


Testing
-------

Works good.


File Attachments
----------------

snapshot3.png
  https://git.reviewboard.kde.org/media/uploaded/files/2013/12/30/a1194a19-4412-43cf-92ff-3bf150bbd38c__snapshot3.png


Thanks,

Sudhendu Kumar

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20131231/e59c82cc/attachment.html>


More information about the Plasma-devel mailing list