Review Request 114741: Add time duration to media item for youtube videos.

[Shantanu Tushar]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114741/#review46470
-----------------------------------------------------------


Works nicely :) Just one nitpick around the hh:mm:ss formatting-


browsingbackends/onlineservices/youtube/youtubemodel.cpp
<https://git.reviewboard.kde.org/r/114741/#comment33189>

    This calculation should go inside QML (view), not C++ (model). From the model you should return the seconds.
    
    You can look at mediacontroller and re-use the existing code there (which converts video duration to hh:mm:ss format)


- Shantanu Tushar


On Dec. 30, 2013, 6:13 p.m., Sudhendu Kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114741/
> -----------------------------------------------------------
> 
> (Updated Dec. 30, 2013, 6:13 p.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> While searching for youtube videos from PMC, it was difficult to differentiate among the videos of same kind but different duration.
> This feature adds the duration of video at top-right corner of thumbnail.
> Snapshot added along with this review.
> 
> 
> Diffs
> -----
> 
>   components/common/LabelOverlay.qml fd722af 
>   components/common/MediaItem.qml ccdc8c2 
>   libs/mediacenter/mediacenter.h 7cdf285 
>   libs/mediacenter/mediacenter.cpp 009ce22 
>   browsingbackends/onlineservices/youtube/youtubemodel.cpp abb4f89 
>   browsingbackends/onlineservices/youtube/youtubemodel.h 47be4ce 
> 
> Diff: https://git.reviewboard.kde.org/r/114741/diff/
> 
> 
> Testing
> -------
> 
> Works good.
> 
> 
> File Attachments
> ----------------
> 
> snapshot3.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2013/12/30/a1194a19-4412-43cf-92ff-3bf150bbd38c__snapshot3.png
> 
> 
> Thanks,
> 
> Sudhendu Kumar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20131231/3a6fa46d/attachment-0001.html>