Review Request 114682: Remove 'X-Plasma-DefaultSize' declarations in metadata.desktop files

[Benjamin Kaiser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114682/
-----------------------------------------------------------

(Updated Dec. 27, 2013, 1:56 p.m.)


Review request for Plasma, Heena Mahour and Sebastian Kügler.


Changes
-------

Added implicit{Width,Height} variables.


Repository: kdeplasma-addons


Description
-------

Removed all 'X-Plasma-DefaultSize' declarations in metadata.desktop files where the corrosponding main QML file contained a minimumHeight and minimumWidth declaration.

Below is a listing of the notes I kept for the items I changed/didn't change.

/applets/bubblemon/plasma-applet-bubblemon.desktop:
Ignored as it has not been moved to qml/is not a metadata.desktop file.

/applets/calculator/package/metadata.desktop:
minimumWidth and mimimumHeight are set in qml, declaration removed.

/applets/comic/package/metadata.desktop:
minimumWidth and mimimumHeight are set in qml, declaration removed.

/applets/konqprofiles/package/metadata.desktop:
minimumWidth and mimimumHeight are set in qml, declaration removed.

/applets/konsoleprofiles/package/metadata.desktop:
minimumWidth and mimimumHeight are set in qml, declaration removed.

/applets/nowplaying/package/metadata.desktop:
minimumWidth and mimimumHeight are set in qml, declaration removed.

/applets/weather/package/metadata.desktop:
minimumWidth and mimimumHeight are set in qml, declaration removed.

/applets/weatherstation/package/metadata.desktop:
minimumWidth and mimimumHeight are set in qml, declaration removed.

/applets/webslice/plasma/plasma-applet-webslice.desktop:
Ignored as it has not been moved to qml/is not a metadata.desktop file.


Diffs (updated)
-----

  applets/calculator/package/contents/ui/calculator.qml b8d802a 
  applets/calculator/package/metadata.desktop a322abb 
  applets/comic/package/contents/ui/main.qml 7b48fd9 
  applets/comic/package/metadata.desktop 5e53f2e 
  applets/konqprofiles/package/contents/ui/konqprofiles.qml 4ad73b5 
  applets/konqprofiles/package/metadata.desktop ebb381c 
  applets/konsoleprofiles/package/contents/ui/konsoleprofiles.qml bea8bfa 
  applets/konsoleprofiles/package/metadata.desktop 4b4cdb8 
  applets/nowplaying/package/contents/ui/nowplaying.qml 6f995d7 
  applets/nowplaying/package/metadata.desktop 93e8ac5 
  applets/weather/package/contents/ui/main.qml cfd3e6e 
  applets/weather/package/metadata.desktop 2bbe453 
  applets/weatherstation/package/contents/ui/main.qml 03d6bc0 
  applets/weatherstation/package/metadata.desktop bf3fe1a 

Diff: https://git.reviewboard.kde.org/r/114682/diff/


Testing
-------


Thanks,

Benjamin Kaiser

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20131227/2d3b04d9/attachment.html>