<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/114682/">https://git.reviewboard.kde.org/r/114682/</a>
     </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Plasma, Heena Mahour and Sebastian Kügler.</div>
<div>By Benjamin Kaiser.</div>


<p style="color: grey;"><i>Updated Dec. 27, 2013, 1:56 p.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added implicit{Width,Height} variables.</pre>
  </td>
 </tr>
</table>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Removed all 'X-Plasma-DefaultSize' declarations in metadata.desktop files where the corrosponding main QML file contained a minimumHeight and minimumWidth declaration.

Below is a listing of the notes I kept for the items I changed/didn't change.

/applets/bubblemon/plasma-applet-bubblemon.desktop:
Ignored as it has not been moved to qml/is not a metadata.desktop file.

/applets/calculator/package/metadata.desktop:
minimumWidth and mimimumHeight are set in qml, declaration removed.

/applets/comic/package/metadata.desktop:
minimumWidth and mimimumHeight are set in qml, declaration removed.

/applets/konqprofiles/package/metadata.desktop:
minimumWidth and mimimumHeight are set in qml, declaration removed.

/applets/konsoleprofiles/package/metadata.desktop:
minimumWidth and mimimumHeight are set in qml, declaration removed.

/applets/nowplaying/package/metadata.desktop:
minimumWidth and mimimumHeight are set in qml, declaration removed.

/applets/weather/package/metadata.desktop:
minimumWidth and mimimumHeight are set in qml, declaration removed.

/applets/weatherstation/package/metadata.desktop:
minimumWidth and mimimumHeight are set in qml, declaration removed.

/applets/webslice/plasma/plasma-applet-webslice.desktop:
Ignored as it has not been moved to qml/is not a metadata.desktop file.</pre>
  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/calculator/package/contents/ui/calculator.qml <span style="color: grey">(b8d802a)</span></li>

 <li>applets/calculator/package/metadata.desktop <span style="color: grey">(a322abb)</span></li>

 <li>applets/comic/package/contents/ui/main.qml <span style="color: grey">(7b48fd9)</span></li>

 <li>applets/comic/package/metadata.desktop <span style="color: grey">(5e53f2e)</span></li>

 <li>applets/konqprofiles/package/contents/ui/konqprofiles.qml <span style="color: grey">(4ad73b5)</span></li>

 <li>applets/konqprofiles/package/metadata.desktop <span style="color: grey">(ebb381c)</span></li>

 <li>applets/konsoleprofiles/package/contents/ui/konsoleprofiles.qml <span style="color: grey">(bea8bfa)</span></li>

 <li>applets/konsoleprofiles/package/metadata.desktop <span style="color: grey">(4b4cdb8)</span></li>

 <li>applets/nowplaying/package/contents/ui/nowplaying.qml <span style="color: grey">(6f995d7)</span></li>

 <li>applets/nowplaying/package/metadata.desktop <span style="color: grey">(93e8ac5)</span></li>

 <li>applets/weather/package/contents/ui/main.qml <span style="color: grey">(cfd3e6e)</span></li>

 <li>applets/weather/package/metadata.desktop <span style="color: grey">(2bbe453)</span></li>

 <li>applets/weatherstation/package/contents/ui/main.qml <span style="color: grey">(03d6bc0)</span></li>

 <li>applets/weatherstation/package/metadata.desktop <span style="color: grey">(bf3fe1a)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/114682/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>




  </div>
 </body>
</html>