Review Request 114566: Plasmate: Port remoteinstaller to Qt5/KF5

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114566/#review45989
-----------------------------------------------------------



plasmate/CMakeLists.txt
<http://git.reviewboard.kde.org/r/114566/#comment32815>

    No point committing commented code.



plasmate/publisher/remoteinstaller/remoteinstaller.cpp
<http://git.reviewboard.kde.org/r/114566/#comment32816>

    This seems wrong.
    
    from kde4support/src/kio/netaccess.h
        static KDE4SUPPORT_DEPRECATED_EXPORT bool mkdir( const QUrl & url, QWidget* window, int permissions = -1 );
    
    
    so you're casting book ok which is uninitialised to permissions - and then using that as the result.
    
    Maybe you can explain why you had to change it?



plasmate/publisher/remoteinstaller/remoteinstallerdialog.cpp
<http://git.reviewboard.kde.org/r/114566/#comment32817>

    You can't make a layout on the stack.
    
    The lifetime of the layout needs to be as long as the RemoteInstallerDialog. This will be deleted as soon as we exit the constructor.


- David Edmundson


On Dec. 20, 2013, 4:02 p.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114566/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2013, 4:02 p.m.)
> 
> 
> Review request for Plasma and Giorgos Tsiapaliokas.
> 
> 
> Repository: plasmate
> 
> 
> Description
> -------
> 
> Hello,
> 
> This patch ports the remoteinstaller to Qt5/KF5.
> 
> 
> Diffs
> -----
> 
>   plasmate/CMakeLists.txt 55e7453 
>   plasmate/publisher/remoteinstaller/remoteinstaller.cpp 5f4de97 
>   plasmate/publisher/remoteinstaller/remoteinstallerdialog.cpp 3b41b33 
> 
> Diff: http://git.reviewboard.kde.org/r/114566/diff/
> 
> 
> Testing
> -------
> 
> I wasn't able to test if it works. Because remoteinstaller is using the KUrlRequester,
> which it segfaults... I have open a thread on the frameworks ML.
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20131221/e7a68e1c/attachment.html>