Review Request 114428: Replaced Text {} by Label {} using PlasmaComponents in mediaelements

[Heena Mahour]

> On Dec. 13, 2013, 7:10 a.m., Shantanu Tushar wrote:
> > mediaelements/mediawelcome/HomeScreenText.qml, line 25
> > <http://git.reviewboard.kde.org/r/114428/diff/1/?file=224648#file224648line25>
> >
> >     Label should pick this up automatically, check if we can remove this.

yeah the color stays same if I remove it 


- Heena


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114428/#review45622
-----------------------------------------------------------


On Dec. 13, 2013, 7:09 a.m., Heena Mahour wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114428/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2013, 7:09 a.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> Replaced Text {} by PlasmaComponents.Label {} 
> 
> 
> Diffs
> -----
> 
>   mediaelements/mediawelcome/BackendsListDelegate.qml e76af63 
>   mediaelements/mediawelcome/CategoriesListDelegate.qml f011bae 
>   mediaelements/mediawelcome/HomeScreenFooter.qml d2c0eb7 
>   mediaelements/mediawelcome/HomeScreenText.qml 35cd20a 
> 
> Diff: http://git.reviewboard.kde.org/r/114428/diff/
> 
> 
> Testing
> -------
> 
> works fine .
> 
> 
> Thanks,
> 
> Heena Mahour
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20131213/63bd79ad/attachment.html>