Review Request 114428: Replaced Text {} by Label {} using PlasmaComponents in mediaelements

[Shantanu Tushar]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114428/#review45622
-----------------------------------------------------------



mediaelements/mediawelcome/BackendsListDelegate.qml
<http://git.reviewboard.kde.org/r/114428/#comment32565>

    This is a workaround, as the id says. It will never be displayed and hence, we should use Text instead of Label as it is lightweight.



mediaelements/mediawelcome/CategoriesListDelegate.qml
<http://git.reviewboard.kde.org/r/114428/#comment32566>

    Same as above



mediaelements/mediawelcome/HomeScreenFooter.qml
<http://git.reviewboard.kde.org/r/114428/#comment32568>

    Please verify that. If it looks the same, then go ahead and remove.



mediaelements/mediawelcome/HomeScreenText.qml
<http://git.reviewboard.kde.org/r/114428/#comment32567>

    Label should pick this up automatically, check if we can remove this.


- Shantanu Tushar


On Dec. 13, 2013, 7:09 a.m., Heena Mahour wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114428/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2013, 7:09 a.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> Replaced Text {} by PlasmaComponents.Label {} 
> 
> 
> Diffs
> -----
> 
>   mediaelements/mediawelcome/BackendsListDelegate.qml e76af63 
>   mediaelements/mediawelcome/CategoriesListDelegate.qml f011bae 
>   mediaelements/mediawelcome/HomeScreenFooter.qml d2c0eb7 
>   mediaelements/mediawelcome/HomeScreenText.qml 35cd20a 
> 
> Diff: http://git.reviewboard.kde.org/r/114428/diff/
> 
> 
> Testing
> -------
> 
> works fine .
> 
> 
> Thanks,
> 
> Heena Mahour
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20131213/bb57f2fd/attachment.html>