Review Request 112142: QQuick item for live updating window thumbnails

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112142/#review38855
-----------------------------------------------------------

Ship it!


purely from an api pov, i would like setWinId not being a slot, then it's perfect

- Marco Martin


On Aug. 18, 2013, 8:22 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112142/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2013, 8:22 a.m.)
> 
> 
> Review request for Plasma and Aaron J. Seigo.
> 
> 
> Description
> -------
> 
> New qquick item in PlasmaCore to render a live updating window
> thumbnail. The implementation uses XCB to redirect the specified
> window using the composite extension. This means a running compositor
> is not required. Through the damage extension the item tracks changes
> to the window and triggers updates of the texture. Furthermore the
> item tracks geometry changes of the window to recreate the window
> pixmap.
>     
> If the pixmap of the window is valid, a texture is generated from it
> using the glx texture from pixmap extension. For this a new optional
> dependency for glx is added. On platform where glx is not available
> (e.g. Windows, Linux with OpenGL ES) this will not get compiled and
> the window's icon is used instead as a fallback.
> 
> ====
> For more info see also the documentation of the item in the header file.
> 
> I plan to also add an egl variant (which is magnitudes easier) once I figure out how to compile Qt to use egl instead of glx for the xcb platform plugin.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 781c56f 
>   src/declarativeimports/core/CMakeLists.txt 75b52b3 
>   src/declarativeimports/core/corebindingsplugin.cpp ae4788e 
>   src/declarativeimports/core/windowthumbnail.h PRE-CREATION 
>   src/declarativeimports/core/windowthumbnail.cpp PRE-CREATION 
>   src/plasma/config-plasma.h.cmake f2da235 
> 
> Diff: http://git.reviewboard.kde.org/r/112142/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Window and it's thumbnail
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/18/windowthumbnail.png
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130829/1471c913/attachment.html>