<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112142/">http://git.reviewboard.kde.org/r/112142/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">purely from an api pov, i would like setWinId not being a slot, then it's perfect</pre>
<br />
<p>- Marco</p>
<br />
<p>On August 18th, 2013, 8:22 a.m. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and Aaron J. Seigo.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Aug. 18, 2013, 8:22 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">New qquick item in PlasmaCore to render a live updating window
thumbnail. The implementation uses XCB to redirect the specified
window using the composite extension. This means a running compositor
is not required. Through the damage extension the item tracks changes
to the window and triggers updates of the texture. Furthermore the
item tracks geometry changes of the window to recreate the window
pixmap.
If the pixmap of the window is valid, a texture is generated from it
using the glx texture from pixmap extension. For this a new optional
dependency for glx is added. On platform where glx is not available
(e.g. Windows, Linux with OpenGL ES) this will not get compiled and
the window's icon is used instead as a fallback.
====
For more info see also the documentation of the item in the header file.
I plan to also add an egl variant (which is magnitudes easier) once I figure out how to compile Qt to use egl instead of glx for the xcb platform plugin.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(781c56f)</span></li>
<li>src/declarativeimports/core/CMakeLists.txt <span style="color: grey">(75b52b3)</span></li>
<li>src/declarativeimports/core/corebindingsplugin.cpp <span style="color: grey">(ae4788e)</span></li>
<li>src/declarativeimports/core/windowthumbnail.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/declarativeimports/core/windowthumbnail.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plasma/config-plasma.h.cmake <span style="color: grey">(f2da235)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112142/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/08/18/windowthumbnail.png">Window and it's thumbnail</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>