Review Request 112150: Port analog clock to Plasma 2 (based on Viranch's branch)

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112150/#review38211
-----------------------------------------------------------

Ship it!


A few minor comments, otherwise it looks good.


plasma/generic/applets/analog-clock/contents/ui/Hand.qml
<http://git.reviewboard.kde.org/r/112150/#comment28236>

    This and the copyright in the other files should include Marco as author



plasma/generic/applets/analog-clock/contents/ui/analogclock.qml
<http://git.reviewboard.kde.org/r/112150/#comment28237>

    should move to the end of the parent Item in the source file



plasma/generic/applets/analog-clock/contents/ui/analogclock.qml
<http://git.reviewboard.kde.org/r/112150/#comment28238>

    could this be made relative, i.e. z: secondHand.z + 1 ?


- Sebastian Kügler


On Aug. 18, 2013, 10:28 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112150/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2013, 10:28 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Diff shows my changes since viranch's code. Full code available at davidedmundson/analog-clock
> 
> 
> Git log below
> --
> 
> Restore config for clock applet
> 
> --
> 
> Remove calendar components.
> Plasma will have it's own Calendar which should be shared
> 
> --
> 
> Scale clock hands to fit current clock size
> 
> --
> 
> Update copyright to reflect actual authors
> 
> 
> --
> Port analog clock to new dataengine + config scheme
> 
> Make the clock use the new PlasmaCore.Datasource to fetch the current
> time
> 
> --
> 
> Update the analog clock to run on plasma 2
> 
> --
> 
> Enable generic/applets directory
> 
> --
> 
> Merge remote-tracking branch 'remotes/origin/plasma/viranch/analogclock' into frameworks-scratch
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/analog-clock/contents/config/config.qml PRE-CREATION 
>   plasma/generic/applets/analog-clock/contents/ui/Calendar.qml 60da3f7 
>   plasma/generic/applets/analog-clock/contents/ui/Cell.qml 2f0376a 
>   plasma/generic/applets/analog-clock/contents/ui/Hand.qml eaa7a9b 
>   plasma/generic/applets/analog-clock/contents/ui/analogclock.qml ad03f18 
>   plasma/generic/applets/analog-clock/contents/ui/configGeneral.qml PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112150/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130820/e51c70c1/attachment.html>