Review Request 112150: Port analog clock to Plasma 2 (based on Viranch's branch)

David Edmundson david at davidedmundson.co.uk
Sun Aug 18 22:28:39 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112150/
-----------------------------------------------------------

Review request for Plasma.


Description
-------

Diff shows my changes since viranch's code. Full code available at davidedmundson/analog-clock


Git log below
--

Restore config for clock applet

--

Remove calendar components.
Plasma will have it's own Calendar which should be shared

--

Scale clock hands to fit current clock size

--

Update copyright to reflect actual authors


--
Port analog clock to new dataengine + config scheme

Make the clock use the new PlasmaCore.Datasource to fetch the current
time

--

Update the analog clock to run on plasma 2

--

Enable generic/applets directory

--

Merge remote-tracking branch 'remotes/origin/plasma/viranch/analogclock' into frameworks-scratch


Diffs
-----

  plasma/generic/applets/analog-clock/contents/config/config.qml PRE-CREATION 
  plasma/generic/applets/analog-clock/contents/ui/Calendar.qml 60da3f7 
  plasma/generic/applets/analog-clock/contents/ui/Cell.qml 2f0376a 
  plasma/generic/applets/analog-clock/contents/ui/Hand.qml eaa7a9b 
  plasma/generic/applets/analog-clock/contents/ui/analogclock.qml ad03f18 
  plasma/generic/applets/analog-clock/contents/ui/configGeneral.qml PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/112150/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130818/e66798a6/attachment.html>


More information about the Plasma-devel mailing list