Review Request 111863: Feature: Folder Preview in Local Pictures Browsing

[Sinny Kumari]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111863/#review37204
-----------------------------------------------------------



browsingbackends/localfiles/localpictures/localpicturesmodel.cpp
<http://git.reviewboard.kde.org/r/111863/#comment27516>

    I am getting some weird behaviour in browse pictures thumbnails. Now, it doesn't show thumbnail for all pictures http://imgur.com/0hZlaqI . please try to reproduce same because I see similar behaviour at many places. 
    
    Right now, reason for same could be that we are asking thumbnail in this manner for all image files and directories. Directory preview works fine now. So, what I am suggesting is call new way of getting decoration only 
    if MediaCenter::IsExpandableRole role is false i.e for directory else keep previous logic (i.e files) for getting thumbnail of pictures.


- Sinny Kumari


On Aug. 5, 2013, 4:33 p.m., Akshay Ratan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111863/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2013, 4:33 p.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar and Sinny Kumari.
> 
> 
> Description
> -------
> 
> Folder Contents(Images) are previewed when we browse the local directories for Pictures.
> 
> 
> Diffs
> -----
> 
>   browsingbackends/localfiles/localpictures/CMakeLists.txt 2acbd59 
>   browsingbackends/localfiles/localpictures/localpicturesmodel.h d61f2a3 
>   browsingbackends/localfiles/localpictures/localpicturesmodel.cpp afb852f 
>   browsingbackends/localfiles/localthumbnailprovider.h PRE-CREATION 
>   browsingbackends/localfiles/localthumbnailprovider.cpp PRE-CREATION 
>   browsingbackends/localfiles/localvideos/CMakeLists.txt 3cac82c 
>   browsingbackends/localfiles/localvideos/localvideosmodel.h 3b4b668 
>   browsingbackends/localfiles/localvideos/localvideosmodel.cpp 6bdf386 
>   browsingbackends/localfiles/localvideos/localvideothumbnailprovider.h d485b11 
>   browsingbackends/localfiles/localvideos/localvideothumbnailprovider.cpp d666ac4 
> 
> Diff: http://git.reviewboard.kde.org/r/111863/diff/
> 
> 
> Testing
> -------
> 
> Yes. Works fine.
> 
> 
> Thanks,
> 
> Akshay Ratan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130806/7aa3c545/attachment-0001.html>