<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111863/">http://git.reviewboard.kde.org/r/111863/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111863/diff/3/?file=176294#file176294line43" style="color: black; font-weight: bold; text-decoration: underline;">browsingbackends/localfiles/localpictures/localpicturesmodel.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">43</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="k">if</span> <span class="p">(</span><span class="n">m_thumbProvider</span><span class="o">-></span><span class="n">hasThumbnail</span><span class="p">(</span><span class="n">url</span><span class="p">))</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I am getting some weird behaviour in browse pictures thumbnails. Now, it doesn't show thumbnail for all pictures http://imgur.com/0hZlaqI . please try to reproduce same because I see similar behaviour at many places.
Right now, reason for same could be that we are asking thumbnail in this manner for all image files and directories. Directory preview works fine now. So, what I am suggesting is call new way of getting decoration only
if MediaCenter::IsExpandableRole role is false i.e for directory else keep previous logic (i.e files) for getting thumbnail of pictures.</pre>
</div>
<br />
<p>- Sinny</p>
<br />
<p>On August 5th, 2013, 4:33 p.m. UTC, Akshay Ratan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma, Shantanu Tushar and Sinny Kumari.</div>
<div>By Akshay Ratan.</div>
<p style="color: grey;"><i>Updated Aug. 5, 2013, 4:33 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Folder Contents(Images) are previewed when we browse the local directories for Pictures.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes. Works fine.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>browsingbackends/localfiles/localpictures/CMakeLists.txt <span style="color: grey">(2acbd59)</span></li>
<li>browsingbackends/localfiles/localpictures/localpicturesmodel.h <span style="color: grey">(d61f2a3)</span></li>
<li>browsingbackends/localfiles/localpictures/localpicturesmodel.cpp <span style="color: grey">(afb852f)</span></li>
<li>browsingbackends/localfiles/localthumbnailprovider.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>browsingbackends/localfiles/localthumbnailprovider.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>browsingbackends/localfiles/localvideos/CMakeLists.txt <span style="color: grey">(3cac82c)</span></li>
<li>browsingbackends/localfiles/localvideos/localvideosmodel.h <span style="color: grey">(3b4b668)</span></li>
<li>browsingbackends/localfiles/localvideos/localvideosmodel.cpp <span style="color: grey">(6bdf386)</span></li>
<li>browsingbackends/localfiles/localvideos/localvideothumbnailprovider.h <span style="color: grey">(d485b11)</span></li>
<li>browsingbackends/localfiles/localvideos/localvideothumbnailprovider.cpp <span style="color: grey">(d666ac4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111863/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>