Review Request 111828: fix link click in notification

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111828/#review36897
-----------------------------------------------------------

Ship it!


Ship It!

- Sebastian Kügler


On Aug. 1, 2013, 1:23 a.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111828/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2013, 1:23 a.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Description
> -------
> 
> handle the linkActivated signal in both popup and notification history.
> 
> now click on link can open browser (or anything it should be) correctly.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/notifications/contents/ui/NotificationDelegate/NotificationDelegate.qml ca7564f 
>   plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml 29a6a2d 
> 
> Diff: http://git.reviewboard.kde.org/r/111828/diff/
> 
> 
> Testing
> -------
> 
> No problem, and seems the drag operation is not affected (if not dragging from link).
> 
> test with:
> notify-send "<a href="https://google.com">test link</a>"
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130801/6a8ac2e0/attachment.html>