Review Request 111828: fix link click in notification

Xuetian Weng wengxt at gmail.com
Thu Aug 1 01:23:12 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111828/
-----------------------------------------------------------

Review request for Plasma and Marco Martin.


Description
-------

handle the linkActivated signal in both popup and notification history.

now click on link can open browser (or anything it should be) correctly.


Diffs
-----

  plasma/generic/applets/notifications/contents/ui/NotificationDelegate/NotificationDelegate.qml ca7564f 
  plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml 29a6a2d 

Diff: http://git.reviewboard.kde.org/r/111828/diff/


Testing
-------

No problem, and seems the drag operation is not affected (if not dragging from link).

test with:
notify-send "<a href="https://google.com">test link</a>"


Thanks,

Xuetian Weng

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130801/2f3149f3/attachment.html>


More information about the Plasma-devel mailing list