Menu branch

Ignat Semenov ignat.semenov at blue-systems.com
Fri Apr 19 07:32:48 UTC 2013


Hello,

git.k.o is finally up again, so here we go:

- Split the flow enum in two - a mega-patch with a mega-commit-message
- Re-did the UI with 4 categories

Concerns:

setLayout() and setAlignment() both trigger a complete relayout of the view. 
Relayouting the view twice is suboptimal, however, in the code there is a 
10ms timer to delay the relayout so as not to block the caller. Should that 
timer be enough to ensure that when those two funcitons are called one after 
another, the view is only relayouted once? Maybe increase the delay a bit?

Other than that, the split has made the code way more readable, in my 
opinion, not to say the it is now easier to configure the layout (I have had 
troubles wrapping my head around the top to bottom right to left stuff as 
well).

Best regards,
Ignat Semenov


More information about the Plasma-devel mailing list