Review Request 110015: Apply settings when clicking Apply button; do not overwrite history when applying settings.

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110015/#review31032
-----------------------------------------------------------

Ship it!


Ship It!

- Sebastian Kügler


On April 14, 2013, 8:39 p.m., Yichao Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110015/
> -----------------------------------------------------------
> 
> (Updated April 14, 2013, 8:39 p.m.)
> 
> 
> Review request for Plasma and Aaron J. Seigo.
> 
> 
> Description
> -------
> 
> This patch fixes two bugs of the pastebin applet.
> 1, It only saves settings when clicking on the Ok button but not on Apply button (so if you clicked Apply and closed the window, the setting will not be saved).
> 2, It overwrite the history when saving settings. This is fixed by also saving the history when ever other settings are saved.
> 
> 
> Diffs
> -----
> 
>   applets/pastebin/pastebin.h 25605d2 
>   applets/pastebin/pastebin.cpp 094e788 
> 
> Diff: http://git.reviewboard.kde.org/r/110015/diff/
> 
> 
> Testing
> -------
> 
> Compiled and installed. The settings are saved correctly and the history is not lost.
> 
> 
> Thanks,
> 
> Yichao Yu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130414/38dee3f2/attachment.html>