Review Request 110015: Apply settings when clicking Apply button; do not overwrite history when applying settings.

Yichao Yu yyc1992 at gmail.com
Sun Apr 14 20:39:04 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110015/
-----------------------------------------------------------

Review request for Plasma and Aaron J. Seigo.


Summary (updated)
-----------------

Apply settings when clicking Apply button; do not overwrite history when applying settings.


Description (updated)
-------

This patch fixes two bugs of the pastebin applet.
1, It only saves settings when clicking on the Ok button but not on Apply button (so if you clicked Apply and closed the window, the setting will not be saved).
2, It overwrite the history when saving settings. This is fixed by also saving the history when ever other settings are saved.


Diffs (updated)
-----

  applets/pastebin/pastebin.h 25605d2 
  applets/pastebin/pastebin.cpp 094e788 

Diff: http://git.reviewboard.kde.org/r/110015/diff/


Testing (updated)
-------

Compiled and installed. The settings are saved correctly and the history is not lost.


Thanks,

Yichao Yu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130414/0e8ac82b/attachment.html>


More information about the Plasma-devel mailing list