Review Request: populate the settings of the rssnow-qml plasmoid

Giorgos Tsiapaliwkas terietor at gmail.com
Wed Sep 26 15:23:47 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106582/
-----------------------------------------------------------

Review request for Plasma.


Description
-------

I have populated the settings of the rssnow-qml plasmoid
and they are identical to the ones of the c++ one.

In order to do that I made the rssnow-qml plasmoid into a hybrid.

After submit of this review I believe that it is ready to be
moved into the kdeplasma-addons and to remove the c++ one.
(I would prefer to open a new review for the move)

Also I have pushed the latest changes(this diff) into the
terietor/rssnow/settings branch in declarative-plasmoids


Diffs
-----

  rssnow/CMakeLists.txt 79b3581 
  rssnow/feedsConfig.ui PRE-CREATION 
  rssnow/generalConfig.ui PRE-CREATION 
  rssnow/package/contents/ui/DropRssEntry.qml PRE-CREATION 
  rssnow/package/contents/ui/ListItemEntry.qml 657b14b 
  rssnow/package/contents/ui/config.ui e1e3409 
  rssnow/package/contents/ui/main.qml a575c29 
  rssnow/plasma-applet-rssnow2.desktop PRE-CREATION 
  rssnow/rssnow.h PRE-CREATION 
  rssnow/rssnow.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/106582/diff/


Testing
-------


Thanks,

Giorgos Tsiapaliwkas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120926/8b95f32c/attachment-0001.html>


More information about the Plasma-devel mailing list