Review Request: rssnow:Add a Drop a feed here

Giorgos Tsiapaliwkas terietor at gmail.com
Wed Sep 26 15:19:27 UTC 2012



> On Dec. 19, 2011, 4:53 p.m., Marco Martin wrote:
> > rssnow/package/contents/ui/DropRssEntry.qml, line 25
> > <http://git.reviewboard.kde.org/r/103472/diff/1/?file=43880#file43880line25>
> >
> >     DropArea has the drop signal, so 
> >     onDrop: {
> >         print(event.url)
> >     }
> >     
> >     should work

I have solved the issue but I have also added other
stuff. So I will close this review and open a new one


- Giorgos


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103472/#review9086
-----------------------------------------------------------


On Dec. 19, 2011, 4:28 p.m., Giorgos Tsiapaliwkas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103472/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2011, 4:28 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Hello,
> 
> I added the "Drop a feed here", but 
> 1.I am still missing the title(look at the screenshot),how can I add one?
> 2.should i make config.ui as the c++ one? (look at the screenshot), and if i make them the same
> how I will connect the signals and slots without c++? I think that the Qt Designer can't do that.
> 3.The "Drop a feed here" doesn't have drag and drop effects.
> I added a DropArea but i don't know if it is correct. I didn't find any onDrop signal,
> so how I will inform the plasmoid about the drop event?
> 4.the ListItemEntry in the main.qml has 3 unknown properties to me link,icon,title, where
> these properties exist?
> 
> 
> Diffs
> -----
> 
>   rssnow/package/contents/ui/DropRssEntry.qml e69de29 
>   rssnow/package/contents/ui/ListItemEntry.qml 657b14b 
>   rssnow/package/contents/ui/main.qml a575c29 
> 
> Diff: http://git.reviewboard.kde.org/r/103472/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> 
>   http://git.reviewboard.kde.org/r/103472/s/378/
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliwkas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120926/63a3004b/attachment.html>


More information about the Plasma-devel mailing list