Review Request: Move plasma tools into plasmate

Aaron J. Seigo aseigo at kde.org
Wed Sep 26 09:47:25 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106580/#review19443
-----------------------------------------------------------

Ship it!


as this generates large diffs, affects multiple repositories simultaneously and is just really moving things around, i don't think this is very well suited to reviewboard. it's better discussed on the mailing list and then just done. in any case, i'm in favour of this. but before it is pushed to master, the current code of plasmate needs to be moved into a sub-directory as well. this will result in plasmate/plasmate/, and perhaps we should think about renaming the repository to plasma-sdk-tools or somesuch at a future point. in any case, once plasmate sources are in a subdirectory as well, please push.

- Aaron J. Seigo


On Sept. 25, 2012, 11:51 p.m., Giorgos Tsiapaliwkas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106580/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2012, 11:51 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> This patch moves the kde-workspace/plasma/generic/tools into plasmate/ .
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 9ff1f27 
>   engineexplorer/CMakeLists.txt PRE-CREATION 
>   engineexplorer/Messages.sh PRE-CREATION 
>   engineexplorer/engineexplorer.h PRE-CREATION 
>   engineexplorer/engineexplorer.cpp PRE-CREATION 
>   engineexplorer/engineexplorer.ui PRE-CREATION 
>   engineexplorer/ktreeviewsearchline.h PRE-CREATION 
>   engineexplorer/ktreeviewsearchline.cpp PRE-CREATION 
>   engineexplorer/main.cpp PRE-CREATION 
>   engineexplorer/serviceviewer.h PRE-CREATION 
>   engineexplorer/serviceviewer.cpp PRE-CREATION 
>   engineexplorer/serviceviewer.ui PRE-CREATION 
>   engineexplorer/titlecombobox.h PRE-CREATION 
>   plasmoidviewer/CMakeLists.txt PRE-CREATION 
>   plasmoidviewer/Messages.sh PRE-CREATION 
>   plasmoidviewer/fullview.h PRE-CREATION 
>   plasmoidviewer/fullview.cpp PRE-CREATION 
>   plasmoidviewer/main.cpp PRE-CREATION 
>   remote-widgets-browser/CMakeLists.txt PRE-CREATION 
>   remote-widgets-browser/Messages.sh PRE-CREATION 
>   remote-widgets-browser/main.cpp PRE-CREATION 
>   remote-widgets-browser/main.qml PRE-CREATION 
>   remote-widgets-browser/plasmafiltermodel.h PRE-CREATION 
>   remote-widgets-browser/plasmafiltermodel.cpp PRE-CREATION 
>   remote-widgets-browser/resources.qrc PRE-CREATION 
>   wallpaperviewer/CMakeLists.txt PRE-CREATION 
>   wallpaperviewer/Messages.sh PRE-CREATION 
>   wallpaperviewer/main.cpp PRE-CREATION 
>   wallpaperviewer/wallpaperwidget.h PRE-CREATION 
>   wallpaperviewer/wallpaperwidget.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/106580/diff/
> 
> 
> Testing
> -------
> 
> How I made the move,
> 
> I used the git subtree command, like
> 
> cd foo/kde-workspace
> git subtree split -P plasma/generic/tools -b someBranch
> cd foo/plasmate
> git fetch foo/kde-workspace someBranch
> git checkout master 
> git merge FETCH_HEAD
> vi CMakeLists.txt(this is the conflict)
> git add CMakeLists.txt
> git commit(I haven't done it yet)
> git push origin master(I have done it yet)
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliwkas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120926/1978b6ea/attachment-0001.html>


More information about the Plasma-devel mailing list