<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106580/">http://git.reviewboard.kde.org/r/106580/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">as this generates large diffs, affects multiple repositories simultaneously and is just really moving things around, i don't think this is very well suited to reviewboard. it's better discussed on the mailing list and then just done. in any case, i'm in favour of this. but before it is pushed to master, the current code of plasmate needs to be moved into a sub-directory as well. this will result in plasmate/plasmate/, and perhaps we should think about renaming the repository to plasma-sdk-tools or somesuch at a future point. in any case, once plasmate sources are in a subdirectory as well, please push.</pre>
<br />
<p>- Aaron J.</p>
<br />
<p>On September 25th, 2012, 11:51 p.m., Giorgos Tsiapaliwkas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliwkas.</div>
<p style="color: grey;"><i>Updated Sept. 25, 2012, 11:51 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch moves the kde-workspace/plasma/generic/tools into plasmate/ .
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">How I made the move,
I used the git subtree command, like
cd foo/kde-workspace
git subtree split -P plasma/generic/tools -b someBranch
cd foo/plasmate
git fetch foo/kde-workspace someBranch
git checkout master
git merge FETCH_HEAD
vi CMakeLists.txt(this is the conflict)
git add CMakeLists.txt
git commit(I haven't done it yet)
git push origin master(I have done it yet)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(9ff1f27)</span></li>
<li>engineexplorer/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>engineexplorer/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>engineexplorer/engineexplorer.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>engineexplorer/engineexplorer.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>engineexplorer/engineexplorer.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>engineexplorer/ktreeviewsearchline.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>engineexplorer/ktreeviewsearchline.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>engineexplorer/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>engineexplorer/serviceviewer.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>engineexplorer/serviceviewer.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>engineexplorer/serviceviewer.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>engineexplorer/titlecombobox.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmoidviewer/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmoidviewer/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmoidviewer/fullview.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmoidviewer/fullview.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmoidviewer/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>remote-widgets-browser/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>remote-widgets-browser/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>remote-widgets-browser/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>remote-widgets-browser/main.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>remote-widgets-browser/plasmafiltermodel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>remote-widgets-browser/plasmafiltermodel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>remote-widgets-browser/resources.qrc <span style="color: grey">(PRE-CREATION)</span></li>
<li>wallpaperviewer/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>wallpaperviewer/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>wallpaperviewer/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>wallpaperviewer/wallpaperwidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>wallpaperviewer/wallpaperwidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106580/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>