api review for DataEngineConsumer

Marco Martin notmart at gmail.com
Tue Sep 25 09:14:22 UTC 2012


On Tue, Sep 25, 2012 at 9:36 AM, Aaron J. Seigo <aseigo at kde.org> wrote:
> On Monday, September 24, 2012 21:09:57 Marco Martin wrote:
>> rationale to remove remoteDataEngine
>
> the difference between dataEngine and remoteDataEngine was passing a QUrl for
> the remote engine. it seemed natural to merge the two things. not only does
> this give us just one method in the public API, but it also makes the split
> between local/remote less evident / obvious, which is what should be worked
> towards imho.
>
>> and finishedWithEngine?
>
> this was not in DataEngineConsumer (DEC), as DataEngine usage is tied to the
> lifespan of a given DEC. the idea is to just delete the DEC when you are
> finished with the engines loaded using it.

ok, so that pretty much clears it, +1 ;)


More information about the Plasma-devel mailing list