api review for DataEngineConsumer

[Marco Martin]

On Mon, Sep 24, 2012 at 4:26 PM, Aaron J. Seigo <aseigo at kde.org> wrote:
> turns out that this is how DataEngineManager was nearly *always* used, and
> when it wasn't (e.g. in individual Applets) it often caused problems. problems
> which DataEngineConsumer avoids.
>
> so ... in these changes to libplasma2, DataEngineManager is now private API
> and DataEngineConsumer is cleaned up a bit and made public.
>
> it is new API, however, with newly written documentation and so could use some
> review. if you can, please take a look at the new DataEngineConsumer in the
> frameworks branch and provide feedback if you have any.

+1 for making the consumer public and the manager private.

api is minuscole and that's great, i just wonder:
rationale to remove remoteDataEngine and finishedWithEngine?

latter one was kinda ugly, hopw you avoided the need for it?

Cheers,
Marco Martin