Review Request: fix crash in runner due to bookmarks
Commit Hook
null at kde.org
Mon Sep 24 15:23:06 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106504/#review19390
-----------------------------------------------------------
This review has been submitted with commit 92f977e05785b201d0f36eb0160b6db915a88a43 by Giorgos Tsiapaliokas to branch master.
- Commit Hook
On Sept. 19, 2012, 11:21 a.m., Giorgos Tsiapaliwkas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106504/
> -----------------------------------------------------------
>
> (Updated Sept. 19, 2012, 11:21 a.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> krunner crashes due to kde-workspace/plasma/generic/runners/bookmarks/browsers/firefox.cpp (Firefox::teardown()).
>
> This patch solves the issue.
>
> Also I fixed the indentation and a mem leak.
>
>
> Diffs
> -----
>
> plasma/generic/runners/bookmarks/browsers/firefox.cpp 4dc02e3
>
> Diff: http://git.reviewboard.kde.org/r/106504/diff/
>
>
> Testing
> -------
>
> since yesterday that I use the patch I haven't see any crashes
>
>
> Thanks,
>
> Giorgos Tsiapaliwkas
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120924/3af20d49/attachment-0001.html>
More information about the Plasma-devel
mailing list