Review Request: fix crash in runner due to bookmarks

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106504/#review19215
-----------------------------------------------------------

Ship it!


just fix the if() note and push away (both to 4.9 branch and master pls)


plasma/generic/runners/bookmarks/browsers/firefox.cpp
<http://git.reviewboard.kde.org/r/106504/#comment15242>

    as already noted, this if is not needed .. otherwise, i agree with Marco G. that this patch is fine once that is changed. so .. remove that if and commit pls :)


- Aaron J. Seigo


On Sept. 19, 2012, 11:21 a.m., Giorgos Tsiapaliwkas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106504/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2012, 11:21 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> krunner crashes due to kde-workspace/plasma/generic/runners/bookmarks/browsers/firefox.cpp (Firefox::teardown()).
> 
> This patch solves the issue.
> 
> Also I fixed the indentation and a mem leak.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/runners/bookmarks/browsers/firefox.cpp 4dc02e3 
> 
> Diff: http://git.reviewboard.kde.org/r/106504/diff/
> 
> 
> Testing
> -------
> 
> since yesterday that I use the patch I haven't see any crashes
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliwkas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120920/b880ec84/attachment.html>