Review Request: The preview action shouldn't be visible all the time
Giorgos Tsiapaliwkas
terietor at gmail.com
Wed Sep 19 11:13:28 UTC 2012
> On Sept. 17, 2012, 4:13 p.m., Sebastian Kügler wrote:
> > mainwindow.cpp, line 975
> > <http://git.reviewboard.kde.org/r/106477/diff/1/?file=85740#file85740line975>
> >
> > Do we setVisible(true) it when we change package?
> >
> > I don't see this in the code, but haven't tried. Something to check...
yes you have right
- Giorgos
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106477/#review19077
-----------------------------------------------------------
On Sept. 17, 2012, 11:14 a.m., Giorgos Tsiapaliwkas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106477/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2012, 11:14 a.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> This patches fixes the above bugs
>
>
> This addresses bugs 305866 and 305867.
> http://bugs.kde.org/show_bug.cgi?id=305866
> http://bugs.kde.org/show_bug.cgi?id=305867
>
>
> Diffs
> -----
>
> mainwindow.cpp b84da4a
>
> Diff: http://git.reviewboard.kde.org/r/106477/diff/
>
>
> Testing
> -------
>
> works
>
>
> Thanks,
>
> Giorgos Tsiapaliwkas
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120919/56cb7b78/attachment-0001.html>
More information about the Plasma-devel
mailing list