Review Request: The preview action shouldn't be visible all the time

Sebastian Kügler sebas at kde.org
Mon Sep 17 16:13:21 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106477/#review19077
-----------------------------------------------------------



mainwindow.cpp
<http://git.reviewboard.kde.org/r/106477/#comment15155>

    Do we setVisible(true) it when we change package?
    
    I don't see this in the code, but haven't tried. Something to check...


- Sebastian Kügler


On Sept. 17, 2012, 11:14 a.m., Giorgos Tsiapaliwkas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106477/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2012, 11:14 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> This patches fixes the above bugs
> 
> 
> This addresses bugs 305866 and 305867.
>     http://bugs.kde.org/show_bug.cgi?id=305866
>     http://bugs.kde.org/show_bug.cgi?id=305867
> 
> 
> Diffs
> -----
> 
>   mainwindow.cpp b84da4a 
> 
> Diff: http://git.reviewboard.kde.org/r/106477/diff/
> 
> 
> Testing
> -------
> 
> works
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliwkas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120917/c3b44ba6/attachment.html>


More information about the Plasma-devel mailing list