Review Request: Fix setting the size of the calendar of clocks

[Ralf Jung]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106441/
-----------------------------------------------------------

(Updated Sept. 15, 2012, 7:32 p.m.)


Review request for Plasma.


Changes
-------

Version 2 of the patch: I tried hard, but so far I have been unable to bring the plasmoid in the broken state described in the bug. I emptied the resizeEvent function as it was not needed, the layout takes care of properly resizing everything - it was partially responsible however for the visual glitch exposed by a missing minimum size. However, I did not remove the entire function as I was not sure whether BC is required or not.


Description
-------

Currently, the size of the calendar opened when clicking a clock is sometimes set incorrectly, see the bug I linked to this review request. This patch fixes the bug by properly resizing the calendar when changing the settings. As the user can't manually resize the calendar, as and the preferred size seems to be ignored, that look slike the best solution to me.


This addresses bug 306762.
    http://bugs.kde.org/show_bug.cgi?id=306762


Diffs (updated)
-----

  libs/plasmaclock/calendar.cpp 7ea70c2 

Diff: http://git.reviewboard.kde.org/r/106441/diff/


Testing
-------

I verified that the bug is fixed - everything behaved as expected.


Thanks,

Ralf Jung

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120915/ba384930/attachment-0001.html>