Review Request: Fix setting the size of the calendar of clocks

[Ralf Jung]

> On Sept. 14, 2012, 3 p.m., Sebastian Kügler wrote:
> > The user can change the size of the calendar in two ways: 
> > 
> > - when the applet is in a panel / popup by dragging the edges
> > - when it's on the desktop, using the applet handle
> > 
> > Applying the config changing it to a different size is wrong in both cases. I'm not sure where the bug stems from, but this doesn't look like a good solution to me.
> >
> 
> Ralf Jung wrote:
>     Oops, I missed that handle as it only appears in the corner(s), and I tried the edges because usually, if something can be resized, one can use either corner or edges.
>     Is it okay to at least set a minimum size? Currently (KDE 4.9.1) with the standalone calendar widget, if I disable events and holidays, shrink the widget as far as possible, and then enable holidays, I get graphical glitches and can't use the right handle - I think the widget extends over it or something like that. There are also layout update issues (e.g. when disabling events and holidays, the actual calendar stays as its old size, only after resizing the Plasma widget it uses the entire space).
> 
> Sebastian Kügler wrote:
>     Sure, if that fixes the problem, or improves its behavior...

Great, that's looking promising here. I will update the diff later today.
Is it okay to remove a no longer needed overload of a virtual function from a class in kde-workspace/libs, or is there some BC constraint?


- Ralf


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106441/#review18976
-----------------------------------------------------------


On Sept. 13, 2012, 9:27 p.m., Ralf Jung wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106441/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2012, 9:27 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Currently, the size of the calendar opened when clicking a clock is sometimes set incorrectly, see the bug I linked to this review request. This patch fixes the bug by properly resizing the calendar when changing the settings. As the user can't manually resize the calendar, as and the preferred size seems to be ignored, that look slike the best solution to me.
> 
> 
> This addresses bug 306762.
>     http://bugs.kde.org/show_bug.cgi?id=306762
> 
> 
> Diffs
> -----
> 
>   libs/plasmaclock/calendar.cpp 7ea70c2 
> 
> Diff: http://git.reviewboard.kde.org/r/106441/diff/
> 
> 
> Testing
> -------
> 
> I verified that the bug is fixed - everything behaved as expected.
> 
> 
> Thanks,
> 
> Ralf Jung
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120915/d1fc4643/attachment-0001.html>