Review Request: Config cleanup on removeActivity

makis marimpis makhsm at gmail.com
Sat Sep 1 15:44:03 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106097/
-----------------------------------------------------------

(Updated Sept. 1, 2012, 3:44 p.m.)


Review request for KDE Runtime and Plasma.


Changes
-------

Aah, i didn't notice that this went to a plugin :}
In a similar way as before the config value is *supposed* to be removed.
The signal is emitted fine, the slot is triggered fine, but the "deleteEntry" does nothing.

Any help is much appreciated :-)


Description
-------

Remove the related configuration entry (which holds the current desktop) when an activity is removed.


Diffs (updated)
-----

  src/service/plugins/virtualdesktopswitch/virtualdesktopswitch.cpp 568e0f9f489e19899dc73ec732488b2ee17c4e3f 
  src/service/plugins/virtualdesktopswitch/virtualdesktopswitch.h 6bf08f0bdec32d078071edb8556a33191ba08d23 

Diff: http://git.reviewboard.kde.org/r/106097/diff/


Testing
-------

Yes


Thanks,

makis marimpis

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120901/c81334e3/attachment.html>


More information about the Plasma-devel mailing list