Review Request: Add "Screen Resolution" to desktop context menu

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106862/#review20360
-----------------------------------------------------------


this menu is already rather full of fairly random "because people think it will be there" things; we don't need to add that further :) the xrandr tray icon already provides quick access to this functionality (and the randr improvements will hopefully even make that somewhat obsolete)

- Aaron J. Seigo


On Oct. 15, 2012, 2:27 a.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106862/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2012, 2:27 a.m.)
> 
> 
> Review request for Plasma, KDE Usability and Dan Vrátil.
> 
> 
> Description
> -------
> 
> This patch adds a context menu entry "Screen Resolution" next to the Configure $containment entry.
> My rationale behind this is that I think many people (especially those from the Windows world, even more with Win7) expect to be able to manipulate the Screen Resolution and arrangement settings right from their Desktop. It is easily adjustable in case kcm_randr gets replaced by the new kscreen-based one.
> Since this was a quick patch I am fine with it not being included, especially since I do not know what plans there are for the new display configuration in terms of easy quickaccess using a plasmoid (ie. common settings such as "Clone", "Projector Only", "Extend Right", etc)
> I initially wanted to add the KCM directly to the backgrounddialog thing but that would have made it too complex, I guess. (I thought there was an easy function to just add an existing kcm to a paged dialog, but I couldn't remember).
> The wording/appearance of the entry could definitly be better (the ellipsis should be dropped there, I think)
> 
> 
> Diffs
> -----
> 
>   plasma/generic/containmentactions/contextmenu/menu.h 7ef79d3 
>   plasma/generic/containmentactions/contextmenu/menu.cpp 33f07e7 
> 
> Diff: http://git.reviewboard.kde.org/r/106862/diff/
> 
> 
> Testing
> -------
> 
> Entry shows up (enabled by default), can be enabled and disabled, and clicking it triggeres the Randr KCM.
> 
> 
> Screenshots
> -----------
> 
> Context menu entry
>   http://git.reviewboard.kde.org/r/106862/s/771/
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121015/8ab61e89/attachment.html>