Review Request: make the DeviceNotifier Plasmoid scale with high-res screens

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107428/#review22548
-----------------------------------------------------------


This is really an issue that needs addressing, thanks for taking time for it.

i'm very in favor of removing all those hardcoded sizes from the code.

however i see two problems with that approach

1) icons are cleanly painted only when they have a size that is the "right" one (16,22,32,48,64,128,512 exported in qml with theme.smallIconSize, smallMediumIconSize etc)  for big sizes doesn't matter if the pixmap ends up being scaled, but small icons really look horrible when scaled (and in the new code there is no check the size ends up being one of those).

2) it's anyways quite arbitrary, so i can easily see each plasmoid using more or less its own logic, with the end result looking a bit like a patchwork.

the"proper" solution i think is to export in Theme the configurable KIconLoader sizes, (Desktop, Toolbar, SmallIcons etc)   and those can be controlled by a kcm, so will be properly set on higher resolution displays

- Marco Martin


On Nov. 23, 2012, 10:11 p.m., Michael Zanetti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107428/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2012, 10:11 p.m.)
> 
> 
> Review request for Plasma and Kai Uwe Broulik.
> 
> 
> Description
> -------
> 
> This adjustst the DeviceNotifier Plasmoid to scale nicely with high resolution screens.
> 
> The patch changes also one label from wordWrapping to clipping behavior because otherwise it messes up the layout.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/devicenotifier/package/contents/ui/ActionItem.qml 3087a07 
>   plasma/generic/applets/devicenotifier/package/contents/ui/DeviceItem.qml 1fab0ef 
>   plasma/generic/applets/devicenotifier/package/contents/ui/devicenotifier.qml f8728d0 
> 
> Diff: http://git.reviewboard.kde.org/r/107428/diff/
> 
> 
> Testing
> -------
> 
> Tested on High res screen at full DPI and at regular DPI values
> 
> 
> Thanks,
> 
> Michael Zanetti
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121126/0ce8ebef/attachment.html>