Review Request: make the DeviceNotifier Plasmoid scale with high-res screens
Jacopo De Simoi
wilderkde at gmail.com
Sat Nov 24 08:46:43 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107428/#review22455
-----------------------------------------------------------
Thanks for addressing this issue, it is a pity that qml makes it so hard to handle such things nicely.
I hope to be able to test this during the weekend; the diff looks reasonable, though.
Thanks
__J
--Device notifier mantainer
- Jacopo De Simoi
On Nov. 23, 2012, 10:11 p.m., Michael Zanetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107428/
> -----------------------------------------------------------
>
> (Updated Nov. 23, 2012, 10:11 p.m.)
>
>
> Review request for Plasma and Kai Uwe Broulik.
>
>
> Description
> -------
>
> This adjustst the DeviceNotifier Plasmoid to scale nicely with high resolution screens.
>
> The patch changes also one label from wordWrapping to clipping behavior because otherwise it messes up the layout.
>
>
> Diffs
> -----
>
> plasma/generic/applets/devicenotifier/package/contents/ui/ActionItem.qml 3087a07
> plasma/generic/applets/devicenotifier/package/contents/ui/DeviceItem.qml 1fab0ef
> plasma/generic/applets/devicenotifier/package/contents/ui/devicenotifier.qml f8728d0
>
> Diff: http://git.reviewboard.kde.org/r/107428/diff/
>
>
> Testing
> -------
>
> Tested on High res screen at full DPI and at regular DPI values
>
>
> Thanks,
>
> Michael Zanetti
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121124/e3659ce6/attachment-0001.html>
More information about the Plasma-devel
mailing list