Review Request: Show a album cover in the track view if a cover is available. At the moment only a placeholder is displayed.

[Sinny Kumari]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107325/#review21985
-----------------------------------------------------------

Ship it!


Thanks for the patch! Looks good to me:)
One small suggestion in screenshot: It would be nice if we can display name of album to which these songs belong. Album name can be placed at top or bottom of icon "tools-media-optical-copy". You may find some better place as well.


browsingbackends/metadatabackends/metadatamusicbackend/metadatamusiccomponents/MediaBrowser.qml
<http://git.reviewboard.kde.org/r/107325/#comment16902>

    remove extra whitespaces



browsingbackends/metadatabackends/metadatamusicbackend/metadatamusiccomponents/MediaBrowser.qml
<http://git.reviewboard.kde.org/r/107325/#comment16903>

    remove extra whitespace at end



browsingbackends/metadatabackends/metadatamusicbackend/metadatamusiccomponents/MediaBrowser.qml
<http://git.reviewboard.kde.org/r/107325/#comment16904>

    remove extra whitespaces



browsingbackends/metadatabackends/metadatamusicbackend/metadatamusiccomponents/MediaBrowser.qml
<http://git.reviewboard.kde.org/r/107325/#comment16905>

    remove extra whitespaces


- Sinny Kumari


On Nov. 14, 2012, 12:09 p.m., Fabian Riethmayer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107325/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2012, 12:09 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Show a album cover in the track view if a cover is available.
> At the moment only a placeholder is displayed.
> 
> If all tracks or all tracks of an artist are selected, no cover is displayed.
> 
> 
> Diffs
> -----
> 
>   browsingbackends/metadatabackends/metadatamusicbackend/metadatamusiccomponents/MediaBrowser.qml 08735a2 
> 
> Diff: http://git.reviewboard.kde.org/r/107325/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Trackview with cover
>   http://git.reviewboard.kde.org/r/107325/s/831/
> 
> 
> Thanks,
> 
> Fabian Riethmayer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121114/026d03e6/attachment-0001.html>