Review Request: Show a album cover in the track view if a cover is available. At the moment only a placeholder is displayed.

Aaron J. Seigo aseigo at kde.org
Wed Nov 14 12:52:09 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107325/#review21980
-----------------------------------------------------------


Great! :) This should get a ShipIt! from sinny, as she's really doing the majority of work and maintenance on it, but it looks good to me.

- Aaron J. Seigo


On Nov. 14, 2012, 12:09 p.m., Fabian Riethmayer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107325/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2012, 12:09 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Show a album cover in the track view if a cover is available.
> At the moment only a placeholder is displayed.
> 
> If all tracks or all tracks of an artist are selected, no cover is displayed.
> 
> 
> Diffs
> -----
> 
>   browsingbackends/metadatabackends/metadatamusicbackend/metadatamusiccomponents/MediaBrowser.qml 08735a2 
> 
> Diff: http://git.reviewboard.kde.org/r/107325/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Trackview with cover
>   http://git.reviewboard.kde.org/r/107325/s/831/
> 
> 
> Thanks,
> 
> Fabian Riethmayer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121114/b0001464/attachment.html>


More information about the Plasma-devel mailing list