Review Request: Plasmate: Port QDialog to KDialog

[Martin Gräßlin]

> On Nov. 7, 2012, 12:33 a.m., Aleix Pol Gonzalez wrote:
> > I'm unsure what's the reasoning behind, but isn't that exactly the opposite direction we want to go with KF5?
> 
> Luis Gabriel Lima wrote:
>     +1
> 
> Aaron J. Seigo wrote:
>     we don't have KF5 yet, however, and feedback from kdereview was to use KDialog. if we want to start making apps using Platform 4 adapt to things coming in KF5, KDE core devel needs to come to consensus on this so we don't get conflicting input :)

I think the problem here is that Krazy2 reports these "should use K class instead of Q class" and the rules are apps under review may not have any Krazy2 issues.

For KWin there are some of these issues and since I know about the direction of KF5 I do not see any need to change it anymore.

So I agree with Aaron that this should be clarified on kcd, but my personal opinion is that we should not adjust the code if we know that it will be deprecated in hopefully a few months.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107230/#review21519
-----------------------------------------------------------


On Nov. 6, 2012, 8:33 p.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107230/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2012, 8:33 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Porting QDialog to KDialog.
> 
> 
> Diffs
> -----
> 
>   plasmate/editors/kconfigxt/standalone/main.cpp a6dfe5d 
>   plasmate/projectmanager/projectmanager.h f95a130 
>   plasmate/projectmanager/projectmanager.cpp 73a6e2d 
>   plasmate/publisher/publisher.h b9b26ba 
>   plasmate/publisher/publisher.cpp 8adc039 
>   plasmate/publisher/remoteinstaller/remoteinstallerdialog.h 89c9a84 
>   plasmate/publisher/remoteinstaller/remoteinstallerdialog.cpp aed72db 
>   plasmate/savesystem/branchdialog.h 4c1f2aa 
>   plasmate/savesystem/branchdialog.cpp 24fc397 
>   plasmate/savesystem/commitdialog.h acb1a81 
>   plasmate/savesystem/commitdialog.cpp cc0f03a 
>   plasmate/savesystem/timeline.cpp d7ea155 
>   plasmate/startpage.cpp ef34a0c 
> 
> Diff: http://git.reviewboard.kde.org/r/107230/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121107/6391f249/attachment-0001.html>