<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107230/">http://git.reviewboard.kde.org/r/107230/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 7th, 2012, 12:33 a.m., <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm unsure what's the reasoning behind, but isn't that exactly the opposite direction we want to go with KF5?</pre>
</blockquote>
<p>On November 7th, 2012, 11:15 a.m., <b>Luis Gabriel Lima</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">+1</pre>
</blockquote>
<p>On November 7th, 2012, 11:57 a.m., <b>Aaron J. Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">we don't have KF5 yet, however, and feedback from kdereview was to use KDialog. if we want to start making apps using Platform 4 adapt to things coming in KF5, KDE core devel needs to come to consensus on this so we don't get conflicting input :)</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think the problem here is that Krazy2 reports these "should use K class instead of Q class" and the rules are apps under review may not have any Krazy2 issues.
For KWin there are some of these issues and since I know about the direction of KF5 I do not see any need to change it anymore.
So I agree with Aaron that this should be clarified on kcd, but my personal opinion is that we should not adjust the code if we know that it will be deprecated in hopefully a few months.</pre>
<br />
<p>- Martin</p>
<br />
<p>On November 6th, 2012, 8:33 p.m., Antonis Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Antonis Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated Nov. 6, 2012, 8:33 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Porting QDialog to KDialog.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasmate/editors/kconfigxt/standalone/main.cpp <span style="color: grey">(a6dfe5d)</span></li>
<li>plasmate/projectmanager/projectmanager.h <span style="color: grey">(f95a130)</span></li>
<li>plasmate/projectmanager/projectmanager.cpp <span style="color: grey">(73a6e2d)</span></li>
<li>plasmate/publisher/publisher.h <span style="color: grey">(b9b26ba)</span></li>
<li>plasmate/publisher/publisher.cpp <span style="color: grey">(8adc039)</span></li>
<li>plasmate/publisher/remoteinstaller/remoteinstallerdialog.h <span style="color: grey">(89c9a84)</span></li>
<li>plasmate/publisher/remoteinstaller/remoteinstallerdialog.cpp <span style="color: grey">(aed72db)</span></li>
<li>plasmate/savesystem/branchdialog.h <span style="color: grey">(4c1f2aa)</span></li>
<li>plasmate/savesystem/branchdialog.cpp <span style="color: grey">(24fc397)</span></li>
<li>plasmate/savesystem/commitdialog.h <span style="color: grey">(acb1a81)</span></li>
<li>plasmate/savesystem/commitdialog.cpp <span style="color: grey">(cc0f03a)</span></li>
<li>plasmate/savesystem/timeline.cpp <span style="color: grey">(d7ea155)</span></li>
<li>plasmate/startpage.cpp <span style="color: grey">(ef34a0c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107230/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>