Review Request: Port the Calculator applet to QML

Romário Rios luizromario at gmail.com
Tue Nov 6 02:42:46 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107001/
-----------------------------------------------------------

(Updated Nov. 6, 2012, 2:42 a.m.)


Review request for Plasma.


Changes
-------

Conformation to http://community.kde.org/Plasma/QMLStyle

(The reported bug still remains, though. Will take a look ASAP)


Description
-------

This diff replaces the C++ Calculator applet by its QMLfied version, which seems to be feature-par with the latter.


Diffs (updated)
-----

  applets/calculator/CMakeLists.txt 732145c 
  applets/calculator/calculator.h f7339be 
  applets/calculator/calculator.cpp 6bc3ddc 
  applets/calculator/package/contents/ui/calculator.qml PRE-CREATION 
  applets/calculator/package/metadata.desktop PRE-CREATION 
  applets/calculator/plasma-applet-calculator.desktop 0760729 

Diff: http://git.reviewboard.kde.org/r/107001/diff/


Testing
-------

Tested as both applet and popupapplet, with the Air theme and the Oxygen theme. It seems to work fine.


Thanks,

Romário Rios

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121106/76b38228/attachment.html>


More information about the Plasma-devel mailing list