Review Request: Port the Calculator applet to QML

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107001/#review21342
-----------------------------------------------------------


this needs to be modified to match http://community.kde.org/Plasma/QMLStyle

things like the opening { of a function goes on the same line: function foo() {

i also noticed a bug when trying it out -> if you enter 36*59= and then press 5 it will show 595. it should instead start a new number sequence once = is pressed, just as it does with other operators. in fact, pressing a number after = should be the same as first pressing AC :)

great work otherwise! can't wait to see this in


applets/calculator/package/contents/ui/calculator.qml
<http://git.reviewboard.kde.org/r/107001/#comment16613>

    id goes first above properties


- Aaron J. Seigo


On Nov. 1, 2012, 11:36 p.m., Romário Rios wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107001/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2012, 11:36 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> This diff replaces the C++ Calculator applet by its QMLfied version, which seems to be feature-par with the latter.
> 
> 
> Diffs
> -----
> 
>   applets/calculator/CMakeLists.txt 732145c 
>   applets/calculator/calculator.h f7339be 
>   applets/calculator/calculator.cpp 6bc3ddc 
>   applets/calculator/package/contents/ui/calculator.qml PRE-CREATION 
>   applets/calculator/package/metadata.desktop PRE-CREATION 
>   applets/calculator/plasma-applet-calculator.desktop 0760729 
> 
> Diff: http://git.reviewboard.kde.org/r/107001/diff/
> 
> 
> Testing
> -------
> 
> Tested as both applet and popupapplet, with the Air theme and the Oxygen theme. It seems to work fine.
> 
> 
> Thanks,
> 
> Romário Rios
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121102/ebd28ed7/attachment-0001.html>