Review Request: Declarative bindings for ToolBox

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107150/#review21294
-----------------------------------------------------------


I'm quite on the fence with this.
I'm not sure it should be the qml containment to explicitly create the toolbox, but more:

the c++ part of the containment scriptengine loads and parses the qml of the toolbox, puts it on scene (toolboxes would go in packages, so the preferredtoolboxplugin stays in place)

the qml of the toolbox will have access to the actions and limited access to containment

the qml containment will have limited access to the toolbox via plasmoid.toolbox

opinions?



plasma/scriptengines/javascript/declarative/internaltoolbox.h
<http://git.reviewboard.kde.org/r/107150/#comment16593>

    probably only the property should be exposed to qml



plasma/scriptengines/javascript/plasmoid/appletinterface.cpp
<http://git.reviewboard.kde.org/r/107150/#comment16592>

    not sure if the name exposed to the containment should be InternalToolBox, either something that is not the containment qml that instantiates it, or just ToolBox


- Marco Martin


On Oct. 31, 2012, 1:41 p.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107150/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2012, 1:41 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> This class, which is exposed through the javascript/declarative scriptengine, exposes some properties of AbstractToolBox to the declarative containment. Specifically, actions, mutability and wether or not its shown (so other windows should be hidden).
> 
> 
> Diffs
> -----
> 
>   plasma/scriptengines/javascript/CMakeLists.txt fe06582 
>   plasma/scriptengines/javascript/declarative/internaltoolbox.h PRE-CREATION 
>   plasma/scriptengines/javascript/declarative/internaltoolbox.cpp PRE-CREATION 
>   plasma/scriptengines/javascript/plasmoid/appletinterface.h 6fc2d74 
>   plasma/scriptengines/javascript/plasmoid/appletinterface.cpp ed5c8ae 
> 
> Diff: http://git.reviewboard.kde.org/r/107150/diff/
> 
> 
> Testing
> -------
> 
> Using this with my proof-of-concept desktop containment, seems to work as expected, for example screen locking changes are picked up as expected.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121101/4fed9771/attachment-0001.html>