Review Request: Plasmate: request to merge terietor/remoteinstaller to master

Giorgos Tsiapaliwkas terietor at gmail.com
Tue May 29 15:42:24 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105032/
-----------------------------------------------------------

(Updated May 29, 2012, 3:42 p.m.)


Review request for Plasma.


Changes
-------

This patch fixes the issues that Aaron has mentioned and also it does the job
connection the KIO::copy process with a slot.

But there are two issues.

1. the connection isn't made
2. plasmapkg -u and kbuildsycoca4 doesn't execute

P.S.: I will give more details.


Description
-------

Hello,

in terietor/remoteinstaller I have create a remote installer.
The goal is to install the projects remotely to another computer.

You access the remote install either inside plasmate or using the plasmaremoteinstaller binary.


Diffs (updated)
-----

  CMakeLists.txt 7e1bf4b 
  publisher/publisher.h ee57cf3 
  publisher/publisher.cpp 11ddf36 
  publisher/remoteinstaller/remoteinstaller.h PRE-CREATION 
  publisher/remoteinstaller/remoteinstaller.cpp PRE-CREATION 
  publisher/remoteinstaller/remoteinstaller.ui PRE-CREATION 
  publisher/remoteinstaller/remoteinstallerdialog.h PRE-CREATION 
  publisher/remoteinstaller/remoteinstallerdialog.cpp PRE-CREATION 
  publisher/remoteinstaller/standalone/main.cpp PRE-CREATION 
  publisher/remoteinstaller/standalone/plasmaremoteinstaller.h PRE-CREATION 
  publisher/remoteinstaller/standalone/plasmaremoteinstaller.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/105032/diff/


Testing
-------

I couldn't find any bugs in the remote installer, but the proccess fails during KIO::copy.
Apparently I am not writing correct something in the fish protocol.
Right now the remote installer tries to do the above

KIO::copy("/home/terietor/.kde4/share/apps/plasmate/project, "fish://user@ip/home/user")

but it fails


Thanks,

Giorgos Tsiapaliwkas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120529/366e94b9/attachment-0001.html>


More information about the Plasma-devel mailing list