Review Request: qml port of showActivityManager (it's just an icon)

[Mark Gaiser]

> On May 20, 2012, 10:24 p.m., Mark Gaiser wrote:
> > Ehm, sorry for nitpicking but why is shipping allowed?
> > It (probably) can't be closed by pressing CTRL+Q and the glow hover is missing...
> > 
> > There is an import to import org.kde.plasma.graphicswidgets 0.1 as PlasmaWidgets which seems useless.
> > 
> > As a side note, i think we need a Icon component to mimic Plasma::IconWidget -- http://api.kde.org/4.x-api/kdelibs-apidocs/plasma/html/classPlasma_1_1IconWidget.html.
> 
> David Edmundson wrote:
>     We sort of do:
>     
>     org.kde.qtextracomponents 0.1 
>     QIconItem
> 
> Mark Gaiser wrote:
>     No, we just do.
>     http://quickgit.kde.org/index.php?p=kde-runtime.git&a=blob&h=6cc3011319d750cb70c4cb98eb5290bf042c4d78&hb=51170ba2615cb695647b07b2b26c9345be318dd6&f=plasma%2Fdeclarativeimports%2Fgraphicswidgets%2Fgraphicswidgetsbindingsplugin.cpp
>     
>     PlasmaWidgets.IconWidget should be the one required. Though it seems to be working a bit differently then PlasmaCore.Svg. Judging from the properties (http://quickgit.kde.org/index.php?p=kdelibs.git&a=blob&h=78f392ee91fc44b218bb1e2fe059628b6dfcd4e4&hb=b91488ff46f0798511447b0b98ffaf81db2b0efb&f=plasma%2Fwidgets%2Ficonwidget.h) it should work somewhat like this:
>     
>     PlasmaWidgets.IconWidget
>     {
>         svg: "widgets/activities"
>     }
>     
>     Note: it uses "svg" rather then "imagePath".. long live consistency ^_-
>     
>     That widget also has the clicked (and double clicked) signal so i think that should be used. No need to put a mousearea on top of it i guess.
>     
>     My guess for this components (without testing! just writing it down here):
>     
>     import QtQuick 1.1
>     import org.kde.plasma.core 0.1 as PlasmaCore
>     import org.kde.plasma.graphicswidgets 0.1 as PlasmaWidgets
>     
>     Item
>     {
>         id: iconContainer
>         property string activeSource: "Status"
>     	
>         PlasmaCore.DataSource
>         {
>             id: dataSource
>             engine: "org.kde.activities"
>             connectedSources: [activeSource]	
>         }
>     	
>         PlasmaCore.ToolTip
>         {
>             id: tooltip
>             mainText: i18n("Show Activity Manager")
>             subText: i18n("Click to show the activity manager")
>             target: iconContainer
>             image: "preferences-activities"	
>         }
>     
>         PlasmaWidgets.IconWidget
>         {
>             svg: "widgets/activities"
>     
>             onClicked:
>             {
>                 var service = dataSource.serviceForSource(activeSource)
>                 var operation = service.operationDescription("toggleActivityManager")
>                 service.startOperationCall(operation)
>             }
>         }
>     }
>     
>     Just my 5 cents.. or 1 euro in this case ;)
> 
> Greg T wrote:
>     Thanks for your input, guys!
>     
>     "It (probably) can't be closed by pressing CTRL+Q"
>     I'am able to close the activity manager by pressing alt+f4, or what are you talking about? ctrl+q doesn't even work with the old version.
>

Sorry, my mistake. The current one works with "Meta + Q". Which i actually find a very strange combination for closing a window... I don't mind if Meta+Q isn't working. I don't have more nitpicking for you, it's oke by me. ^_^

I do would like someone else of this area to agree again since the code changed quite a bit compared to revision 1.


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104959/#review14005
-----------------------------------------------------------


On May 21, 2012, 6:46 p.m., Greg T wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104959/
> -----------------------------------------------------------
> 
> (Updated May 21, 2012, 6:46 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Hello, I've played around a bit with the new qml stuff. Basically this port works the same way as the c++ version. Though the icon doesn't glow on mouse hover. How can I fix that?
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/applets/CMakeLists.txt 731c70c 
>   plasma/desktop/applets/showActivityManager/CMakeLists.txt 592f38f 
>   plasma/desktop/applets/showActivityManager/Messages.sh 0f07ff5 
>   plasma/desktop/applets/showActivityManager/package/contents/ui/main.qml PRE-CREATION 
>   plasma/desktop/applets/showActivityManager/package/metadata.desktop PRE-CREATION 
>   plasma/desktop/applets/showActivityManager/plasma-applet-org.kde.showActivityManager.desktop 98e9bd6 
>   plasma/desktop/applets/showActivityManager/showActivityManager.h f58fbb7 
>   plasma/desktop/applets/showActivityManager/showActivityManager.cpp e77df0d 
>   plasma/generic/dataengines/activities/activities.operations f9ce034 
>   plasma/generic/dataengines/activities/activityjob.cpp 7fe8823 
> 
> Diff: http://git.reviewboard.kde.org/r/104959/diff/
> 
> 
> Testing
> -------
> 
> click: activity manager comes up
> click again: manager vanishes!
> 
> 
> Thanks,
> 
> Greg T
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120521/cf2a070a/attachment-0001.html>