<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104959/">http://git.reviewboard.kde.org/r/104959/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 20th, 2012, 10:24 p.m., <b>Mark Gaiser</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ehm, sorry for nitpicking but why is shipping allowed?
It (probably) can't be closed by pressing CTRL+Q and the glow hover is missing...
There is an import to import org.kde.plasma.graphicswidgets 0.1 as PlasmaWidgets which seems useless.
As a side note, i think we need a Icon component to mimic Plasma::IconWidget -- http://api.kde.org/4.x-api/kdelibs-apidocs/plasma/html/classPlasma_1_1IconWidget.html.</pre>
</blockquote>
<p>On May 21st, 2012, 12:35 a.m., <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">We sort of do:
org.kde.qtextracomponents 0.1
QIconItem</pre>
</blockquote>
<p>On May 21st, 2012, 12:44 p.m., <b>Mark Gaiser</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No, we just do.
http://quickgit.kde.org/index.php?p=kde-runtime.git&a=blob&h=6cc3011319d750cb70c4cb98eb5290bf042c4d78&hb=51170ba2615cb695647b07b2b26c9345be318dd6&f=plasma%2Fdeclarativeimports%2Fgraphicswidgets%2Fgraphicswidgetsbindingsplugin.cpp
PlasmaWidgets.IconWidget should be the one required. Though it seems to be working a bit differently then PlasmaCore.Svg. Judging from the properties (http://quickgit.kde.org/index.php?p=kdelibs.git&a=blob&h=78f392ee91fc44b218bb1e2fe059628b6dfcd4e4&hb=b91488ff46f0798511447b0b98ffaf81db2b0efb&f=plasma%2Fwidgets%2Ficonwidget.h) it should work somewhat like this:
PlasmaWidgets.IconWidget
{
svg: "widgets/activities"
}
Note: it uses "svg" rather then "imagePath".. long live consistency ^_-
That widget also has the clicked (and double clicked) signal so i think that should be used. No need to put a mousearea on top of it i guess.
My guess for this components (without testing! just writing it down here):
import QtQuick 1.1
import org.kde.plasma.core 0.1 as PlasmaCore
import org.kde.plasma.graphicswidgets 0.1 as PlasmaWidgets
Item
{
id: iconContainer
property string activeSource: "Status"
PlasmaCore.DataSource
{
id: dataSource
engine: "org.kde.activities"
connectedSources: [activeSource]
}
PlasmaCore.ToolTip
{
id: tooltip
mainText: i18n("Show Activity Manager")
subText: i18n("Click to show the activity manager")
target: iconContainer
image: "preferences-activities"
}
PlasmaWidgets.IconWidget
{
svg: "widgets/activities"
onClicked:
{
var service = dataSource.serviceForSource(activeSource)
var operation = service.operationDescription("toggleActivityManager")
service.startOperationCall(operation)
}
}
}
Just my 5 cents.. or 1 euro in this case ;)</pre>
</blockquote>
<p>On May 21st, 2012, 6:46 p.m., <b>Greg T</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for your input, guys!
"It (probably) can't be closed by pressing CTRL+Q"
I'am able to close the activity manager by pressing alt+f4, or what are you talking about? ctrl+q doesn't even work with the old version.
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry, my mistake. The current one works with "Meta + Q". Which i actually find a very strange combination for closing a window... I don't mind if Meta+Q isn't working. I don't have more nitpicking for you, it's oke by me. ^_^
I do would like someone else of this area to agree again since the code changed quite a bit compared to revision 1.</pre>
<br />
<p>- Mark</p>
<br />
<p>On May 21st, 2012, 6:46 p.m., Greg T wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Greg T.</div>
<p style="color: grey;"><i>Updated May 21, 2012, 6:46 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hello, I've played around a bit with the new qml stuff. Basically this port works the same way as the c++ version. Though the icon doesn't glow on mouse hover. How can I fix that?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">click: activity manager comes up
click again: manager vanishes!</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/desktop/applets/CMakeLists.txt <span style="color: grey">(731c70c)</span></li>
<li>plasma/desktop/applets/showActivityManager/CMakeLists.txt <span style="color: grey">(592f38f)</span></li>
<li>plasma/desktop/applets/showActivityManager/Messages.sh <span style="color: grey">(0f07ff5)</span></li>
<li>plasma/desktop/applets/showActivityManager/package/contents/ui/main.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/desktop/applets/showActivityManager/package/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/desktop/applets/showActivityManager/plasma-applet-org.kde.showActivityManager.desktop <span style="color: grey">(98e9bd6)</span></li>
<li>plasma/desktop/applets/showActivityManager/showActivityManager.h <span style="color: grey">(f58fbb7)</span></li>
<li>plasma/desktop/applets/showActivityManager/showActivityManager.cpp <span style="color: grey">(e77df0d)</span></li>
<li>plasma/generic/dataengines/activities/activities.operations <span style="color: grey">(f9ce034)</span></li>
<li>plasma/generic/dataengines/activities/activityjob.cpp <span style="color: grey">(7fe8823)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104959/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>