Review Request: Add Tilt-Wheel, "XButton1", and "XButton2" support for Kickoff GUI

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104406/#review11935
-----------------------------------------------------------


This review has been submitted with commit 3d216ac247e92575830a7a99c2d0b849b069f103 by Rick Stockton to branch KDE/4.8.

- Commit Hook


On March 26, 2012, 5:10 p.m., Richard Stockton wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104406/
> -----------------------------------------------------------
> 
> (Updated March 26, 2012, 5:10 p.m.)
> 
> 
> Review request for Plasma, Kevin Ottens, Aaron J. Seigo, and Martin Gräßlin.
> 
> 
> Description
> -------
> 
> Workaround removal of the "Back Button" (in 4.7): In the
> "Applications" GUI, users with tilt-wheel mice can use "Tilt-Left"
> as a "Back Button" equivalent. And, if the focused item is a
> Parent for other items, "Tilt-Right" will move to the right,
> expanding the Children.
> 
> In addition: For "gamer" mice with thumb buttons, "XButton1"
> (AKA the "back" button) is made to work just like the "Tilt-Left"
> Wheel Event; and "XButton2" is made to work just like "Tilt-Right".
> 
> 
> This addresses bug 289519.
>     http://bugs.kde.org/show_bug.cgi?id=289519
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/applets/kickoff/ui/flipscrollview.h bf12b9c 
>   plasma/desktop/applets/kickoff/ui/flipscrollview.cpp 98bc0bd 
> 
> Diff: http://git.reviewboard.kde.org/r/104406/diff/
> 
> 
> Testing
> -------
> 
> Compiled, Built and Run. (Although another function, which I did not touch, provokes two "unused variable" warnings).
> My desktop is otherwise 4.8.1, and I am using this code "in production". 
> New buttons work; Tilt wheel works; I have seen no regressions.
> 
> 
> Thanks,
> 
> Richard Stockton
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120328/2478d443/attachment.html>