Review Request: Couple of fixes to QML ScrollBar component

Viranch Mehta viranch.mehta at gmail.com
Sun Mar 25 02:59:35 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104402/
-----------------------------------------------------------

Review request for Plasma.


Description
-------

This patch fixes following issues with QML Scrollbar component:

- The hover and non-hover arrow images in vertical scrollbars are the same.
- The down/right arrows are connected to events of mousearea of up/left arrows.
- The mouseareas of the arrows do not have hoverEnabled property set to true. This is required to use their containsMouse property.


Diffs
-----

  plasma/declarativeimports/plasmacomponents/qml/private/ScrollBarDelegate.qml 15ee7aa 

Diff: http://git.reviewboard.kde.org/r/104402/diff/


Testing
-------

I didn't know how to test these from Gallery.qml (what command?). Tested, however, by putting in a test plasmoid. Works well now.


Thanks,

Viranch Mehta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120325/6a5665c8/attachment.html>


More information about the Plasma-devel mailing list