Review Request: Add the -DPHONON_INSTALL_QT_EXTENSIONS_INTO_SYSTEM_QT=TRUE option into the CMakeLists.txt

Shantanu Tushar Jha shaan7in at gmail.com
Sun Mar 25 02:15:54 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104401/#review11826
-----------------------------------------------------------


Hi, thanks for the patch. However PMC now uses QtMultimediaKit from Qt Mobility instead of Phonon (for the time being until stuff is stable and merged to master) and so for now the patch won't be needed :)

- Shantanu Tushar Jha


On March 24, 2012, 9:11 p.m., Giorgos Tsiapaliwkas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104401/
> -----------------------------------------------------------
> 
> (Updated March 24, 2012, 9:11 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Hello,
> 
> until now in order to build PMC we needed to add -DPHONON_INSTALL_QT_EXTENSIONS_INTO_SYSTEM_QT=TRUE as a cmake option.
> This patch fixes the issue.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt aed58e9 
> 
> Diff: http://git.reviewboard.kde.org/r/104401/diff/
> 
> 
> Testing
> -------
> 
> It compiles and installs successfully
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliwkas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120325/e0478f28/attachment.html>


More information about the Plasma-devel mailing list