Review Request: Merge the final and fixed QML battery monitor to master.

[Viranch Mehta]

> On March 20, 2012, 10:27 a.m., Sebastian Kügler wrote:
> > plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml, line 97
> > <http://git.reviewboard.kde.org/r/104226/diff/7/?file=53144#file53144line97>
> >
> >     horizontalAlignment: Text.AlignRight

This doesn't work for some reason (the width of the Label item is same as that required by the painted text, not the width of the cell it is in).

Instead of that, anchors.right: parent.right is used.


> On March 20, 2012, 10:27 a.m., Sebastian Kügler wrote:
> > plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml, line 81
> > <http://git.reviewboard.kde.org/r/104226/diff/7/?file=53144#file53144line81>
> >
> >     showRemainingTime?

There is added condition: text!="" && showRemainingTime elsewhere. Hence here is simply connected to it.


> On March 20, 2012, 10:27 a.m., Sebastian Kügler wrote:
> > plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml, line 130
> > <http://git.reviewboard.kde.org/r/104226/diff/7/?file=53144#file53144line130>
> >
> >     sleepButton and hibernateButton should be hidden when the system does not support it. Looks like this was forgotten here. Did you make sure it works?
> >     
> >     It's exposed in the dataengine, in "Sleep States", keys: "Suspend", "Hibernate".
> >     
> >     Could be as simple as visible: powermanagmentEngine.data["Sleep States"]["Suspend"] etc...

Yes it was forgotten, thanks for pointing out. Added the visible condition.


On March 20, 2012, 10:27 a.m., Viranch Mehta wrote:
> > When installing from the plasma/viranch/powermanagementservices branch, I'm getting this error during installation:
> > 
> > CMake Error at applets/batterymonitor/cmake_install.cmake:56 (FILE):
> >   file INSTALL cannot find
> >   "/home/sebas/kdesvn/src/kde-workspace/plasma/generic/applets/batterymonitor/battery-oxygen.svgz".
> > 
> > Can you have a look?

Fixed. I'd recommend not to merge it from that branch though, because it also has lock_logout QML applet and few other things that might cause a lot of merge conflicts. Use the attached diff for merging.


- Viranch


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104226/#review11650
-----------------------------------------------------------


On March 20, 2012, 9:44 p.m., Viranch Mehta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104226/
> -----------------------------------------------------------
> 
> (Updated March 20, 2012, 9:44 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> I fixed the QML battery monitor to be fairly usable and this diff merges it to master.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/CMakeLists.txt 2dedcb2 
>   plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION 
>   plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION 
>   plasma/generic/applets/batterymonitor/README.txt PRE-CREATION 
>   plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz PRE-CREATION 
>   plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION 
>   plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 5572fcb 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 
>   plasma/generic/dataengines/powermanagement/powermanagementservice.operations ad1301f 
> 
> Diff: http://git.reviewboard.kde.org/r/104226/diff/
> 
> 
> Testing
> -------
> 
> Applet and dataengine both tested and work fine.
> 
> 
> Screenshots
> -----------
> 
> 
>   http://git.reviewboard.kde.org/r/104226/s/482/
> 
> 
> Thanks,
> 
> Viranch Mehta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120320/b345ab88/attachment.html>