Review Request: Merge the final and fixed QML battery monitor to master.

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104226/#review11650
-----------------------------------------------------------


Looking better, I think the translation issues are resolved now. There's still a few things missing here and there, but I think we're pretty close. Good work!


plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml
<http://git.reviewboard.kde.org/r/104226/#comment9235>

    showRemainingTime?



plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml
<http://git.reviewboard.kde.org/r/104226/#comment9236>

    horizontalAlignment: Text.AlignRight



plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml
<http://git.reviewboard.kde.org/r/104226/#comment9237>

    horizontalAlignment: Text.AlignRight



plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml
<http://git.reviewboard.kde.org/r/104226/#comment9238>

    sleepButton and hibernateButton should be hidden when the system does not support it. Looks like this was forgotten here. Did you make sure it works?
    
    It's exposed in the dataengine, in "Sleep States", keys: "Suspend", "Hibernate".
    
    Could be as simple as visible: powermanagmentEngine.data["Sleep States"]["Suspend"] etc...


When installing from the plasma/viranch/powermanagementservices branch, I'm getting this error during installation:

CMake Error at applets/batterymonitor/cmake_install.cmake:56 (FILE):
  file INSTALL cannot find
  "/home/sebas/kdesvn/src/kde-workspace/plasma/generic/applets/batterymonitor/battery-oxygen.svgz".

Can you have a look?

- Sebastian Kügler


On March 14, 2012, 6:46 p.m., Viranch Mehta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104226/
> -----------------------------------------------------------
> 
> (Updated March 14, 2012, 6:46 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> I fixed the QML battery monitor to be fairly usable and this diff merges it to master.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION 
>   plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION 
>   plasma/generic/applets/batterymonitor/README.txt PRE-CREATION 
>   plasma/generic/applets/CMakeLists.txt 2dedcb2 
>   plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml PRE-CREATION 
>   plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION 
>   plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 5572fcb 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 
>   plasma/generic/dataengines/powermanagement/powermanagementservice.operations ad1301f 
> 
> Diff: http://git.reviewboard.kde.org/r/104226/diff/
> 
> 
> Testing
> -------
> 
> Applet and dataengine both tested and work fine.
> 
> 
> Screenshots
> -----------
> 
> 
>   http://git.reviewboard.kde.org/r/104226/s/464/
> 
> 
> Thanks,
> 
> Viranch Mehta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120320/4be6f095/attachment-0001.html>