Review Request: Fix the minimum size of some applets

Aaron J. Seigo aseigo at kde.org
Thu Jun 28 16:39:21 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105234/#review15224
-----------------------------------------------------------


patch seems broken, perhaps was not made against current master. can you re-send the patch?

- Aaron J. Seigo


On June 22, 2012, 6:17 a.m., Maarten De Meyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105234/
> -----------------------------------------------------------
> 
> (Updated June 22, 2012, 6:17 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> This fixes the minimum size of the following applets: showdashboard, systemloadviewer, pastebin, weatherstation and timer.
> Some sizes were to small, so there were visual glitches and some applets had no minimum value set.
> 
> I have no commit rights.
> 
> 
> Diffs
> -----
> 
>   applets/pastebin/pastebin.cpp 208e6a3 
>   applets/showdashboard/showdashboard.h 695347f 
>   applets/showdashboard/showdashboard.cpp 1c2f623 
>   applets/systemloadviewer/systemloadviewer.cpp b852256 
>   applets/timer/timer.cpp ba5ee66 
>   applets/weatherstation/weatherstation.h 6d4ae24 
>   applets/weatherstation/weatherstation.cpp 8ada9c2 
> 
> Diff: http://git.reviewboard.kde.org/r/105234/diff/
> 
> 
> Testing
> -------
> 
> Run the applets with their new minimum size, and minimized.
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120628/0466f93c/attachment.html>


More information about the Plasma-devel mailing list